Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2803] Return item label and DOID #2404

Merged
merged 1 commit into from
Nov 17, 2023
Merged

[DUOS-2803] Return item label and DOID #2404

merged 1 commit into from
Nov 17, 2023

Conversation

fboulnois
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2803

Summary

Return DOID instead of the disease when Disease Restriction is selected.

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois force-pushed the fb-duos-2803-fix-dataset-data-use branch from 18d3ab4 to 0162c8a Compare November 16, 2023 22:13
@fboulnois fboulnois force-pushed the fb-duos-2803-fix-dataset-data-use branch from 0162c8a to 4ed4a9b Compare November 17, 2023 14:43
@fboulnois fboulnois marked this pull request as ready for review November 17, 2023 14:44
@fboulnois fboulnois requested a review from a team as a code owner November 17, 2023 14:44
rushtong
rushtong approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍🏽

hams7504
hams7504 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@hams7504 hams7504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fboulnois fboulnois merged commit 0154ff9 into develop Nov 17, 2023
9 checks passed
@fboulnois fboulnois deleted the fb-duos-2803-fix-dataset-data-use branch November 17, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hams7504 hams7504 hams7504 approved these changes

@rushtong rushtong rushtong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fboulnois @rushtong @hams7504